Remove libcurl dependency #9
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Unix builds need not depends on libcurl: https://github.com/HowardHinnant/date/blob/6e921e1b1d21e84a5c82416ba7ecd98e33a436d0/CMakeLists.txt#L154-L158 Also libcurl properly encodes runtime exports, so its presence in the `run` section is not required: https://github.com/conda-forge/curl-feedstock/blob/3d6c4469eb66a73b74f9f457b7a63f8713829354/recipe/meta.yaml#L47-L49 Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
only_make_windows_depends_on_libcurl
branch
from
eaa86ff
to
56fedf4
Compare
jjerphan
changed the title
There was a problem hiding this comment.
Hello @jjerphan. The condition for the unix build dependency on libcurl is:
if( NOT USE_SYSTEM_TZ_DB AND NOT MANUAL_TZ_DB )
In the build.sh file,
cmake -DCMAKE_INSTALL_PREFIX=$PREFIX $SRC_DIR -DCMAKE_INSTALL_LIBDIR=lib -DBUILD_SHARED_LIBS=ON -DUSE_SYSTEM_TZ_DB=ON -DBUILD_TZ_LIB=ON -DCMAKE_CXX_FLAGS="-fPIC" -DCMAKE_BUILD_TYPE=Release $CMAKE_CXX_FLAGS
the DUSE_SYSTEM_TZ_DB is indeed set to ON.
The option is ON as well for the windows build.
How do you justify keeping the dependency for windows if you remove it for unix?
|
Hi @pidefrem Thank you for making this observation. The dependency might also be removed for Windows, indeed. To be fair with you, I have not looked into that further as the project I work only depends on this library on unix (effectively when it is built against libcpp). I am currently off, but I may have a look then. Feel free to modify this PR or merge it. |
Signed-off-by: Julien Jerphanion <[email protected]>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Signed-off-by: Julien Jerphanion <[email protected]>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
pidefrem
changed the title
|
I believe the dependency on |
|
Actually HowardHinnant/date#611. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Unix builds need not depends on libcurl:
howardhinnant_date-feedstock/recipe/build.sh
Line 16 in 091f6a2
Also libcurl properly encodes runtime requirements, so its presence in the
runsection is not required.